Hello there,
I am new with datawarehousing and hope someone can help me out with this problem

.
This is my current situation. I have two very large tables. Table1 has a one-to-many relationship with Table2 (Table1-<Table2).
Now I would like to create a datawarehouse implementation for this structure. I was thinking about putting all the additives of both tables into one fact_table and create a dimension for both tables. So the result would be:
dim_table1 --< fact_tabe >-- dim_table2
What are your thoughts on this ? Does this seem/feel right or should I create a separate fact_table for both Table1 and Table2 ? (I also have a dim_time and dim_date, but I don't think that is relevant for this question)