I reckon your idea sounds fine... But...
If I have you as my friend, does that instantly make me your friend?
Code:
SELECT user_id
, friend_id
FROM my_friends
WHERE <my user id> IN (user_id, friend_id)
If so the above will catch it.
If not simply change the where clause to read
Code:
WHERE <my user id> = friend_id