Yes, your trigger is correct.
Sequences always return integer values - by default, starting from 1 and incrementing by 1 (though there may be gaps). You can modify the starting and increment values if you need to. The column in the table should just be a NUMBER, or you can specify NUMBER(size,0) if you like, as long as size is big enough.