Hi All

I am rather frustrated with a subroutine that is supposed to does the following.

Reads a date from a file
removes the slashes
return the new values

This is the subroutine to do this
sub ReadFile {
$inputfilename = "$ENV{'PCRESCRIPT'}/config/effectivedate";
open( INFILE, "< $inputfilename" ) or die "Can't open $inputfilename : $!";
while( <INFILE> )
{
chomp;
$line = $_;
$line=~ s/\///g;
$datval= $line;
return "$datval\n";
} close (INFILE); }

In my second script, I would like to set a variable to this returned value. This is where I get stuck. This is how I am calling this routine in my second script.

#!/usr/bin/perl
require "/local5/depfa453/PCRESCRIPTS/batch/RUN/routinefile.pl";
$PCREDATE=ReadFile($datval);

Firstly, I hope I'm in the right direction but I get this error

routinefile.pl did not return a true value at ./routinetest.pl line 2

Any suggestions would be appreciated.

Regards

does it only return one line?


this line:

$PCREDATE=ReadFile($datval);

should just be:

$PCREDATE=ReadFile();

because you are not passing $datval to the sub routine, only getting a value back.

(kevin covered it just fine, redundant comment removed.)