Can anyone tell me whats wrong with this code. It gets called from an onSubmit statement in the form code. The alert is shown, but the function always returns true. If I take the if statement out and just return false then it works properly. Any suggestions?

<? echo("<script Language=\"JAVASCRIPT\">

function ValidateForm()
{
alert (\"Test alert\");

if (username==\"validuser\")
{
return true;
}
else
{
return false;
}

}
</script>"); ?>

If what you're saying is that you have a form with a field named "username", and you want to check for the value it contains, then you should write it this way:

document.forms[0].elements["username"].value=="validuser"

Bye!

where does the PHP come into it? Is the alert after the form has been processed or prior to the submit happening?

sarah - This is a javascript question, unrelated to PHP.

shores - You've got it right.

cmptguru - You need to study how javascript works before trying to write PHP code that generates javascript Mainly study the DOM (Document Object Module), which is how you use javascript to interact with the html document.

There are many ways to do this very thing depending on your target audience (how old their browser is and if it's IE or something else) and how your page is layed out.

May I suggest
http://www.w3schools.com/js/default.asp
and
http://www.w3schools.com/dhtml/default.asp

Duh, I could see that! I was trying to find out from cmptrguru7 what exactly was going on so I take him/her a step further.

Using Javascript & PHP together is one of the biggest mental hurdles for some coders I reckon.

Sorry sarah, I knew you realized that. Javascript + PHP -is- a pretty big challenge at first.

I was just flying through some responses and I guess I made that one a little too short. ... should have put "sarah - You're right, this is a javascript problem"

cmptguru: any questions / problems?

I have solved my problem thank you for your help.