Getting Information in upperCase

firoz.raj · #1 (**permalink**) 08-08-09, 05:55

Simple made programme for testing purpose.user take input from 1 to nine.and function convert that numeric number into text like one two ...nine.
function is working fine .but the number in words is not comming in Upper case.Kindly let me know the idea.any help would be highly appreciated.

Code:

Public Function NumberToWords(x As Integer) As String 
  Dim Numbers(9) As String 
     Numbers(1) = "One" 
     Numbers(2) = "Two" 
     Numbers(3) = "Three" 
     Numbers(4) = "Four" 
     Numbers(5) = "Five" 
     Numbers(6) = "Six" 
     Numbers(7) = "Seven" 
     Numbers(8) = "Eight" 
     Numbers(9) = "Nine" 
    Select Case Val(x) 
          Case 1: NumberToWords = "One" 
          Case 2: NumberToWords = "Two" 
          Case 3: NumberToWords = "Three" 
          Case 4: NumberToWords = "Four" 
                  MsgBox (NumberToWords) 
          Case 5: NumberToWords = "Five" 
                  MsgBox (NumberToWords) 
          Case 6: NumberToWords = "Six" 
          Case 7: NumberToWords = "Seven" 
          Case 8: NumberToWords = "Eight" 
          Case 9: NumberToWords = "Nine" 
        Case Else: NumberToWords = "" 
      End Select 
  
End Function 


Private Sub TxtAmount_KeyPress(KeyAscii As Integer) 
KeyAscii = Asc(UCase(Chr(KeyAscii))) 
End Sub 

Private Sub TxtAmount_LostFocus() 
Dim Amount As Integer 
Amount = Val(TxtAmount.Text) 
TxtPaymentInWords.Text = NumberToWords(Amount) 
TxtPaymentInWords.SetFocus 
End Sub 


Private Sub TxtPaymentInWords_KeyPress(KeyAscii As Integer) 
KeyAscii = Asc(UCase(Chr(KeyAscii))) 
End Sub

loquin · #2 (**permalink**) 08-10-09, 16:15

First - What about zero???

The NumberToWords code can be simplified to

Code:

Public Function NumberToWords(X As Integer) As String 
  Dim Numbers(9) As String 

  Numbers(0) = "Zero"
  Numbers(1) = "One"
  Numbers(2) = "Two"
  Numbers(3) = "Three"
  Numbers(4) = "Four"
  Numbers(5) = "Five"
  Numbers(6) = "Six"
  Numbers(7) = "Seven"
  Numbers(8) = "Eight"
  Numbers(9) = "Nine" 

  Select Case  X

    Case 0 To 9
      NumberToWords = Numbers(X)

    Case Else
      NumberToWords = "" 

  End Select 
  
End Function

Next. The keypress event happens BEFORE any validation or LostFocus event. You are converting any single character to upper case, but that doesn't affect the number. Then, on the lost focus event, you're converting a number to a text string which represents that number, but you're not converting to upper case THEN. That's where you should convert it, or, if it needs to happen earlier, the earliest possible place you could do so is within the NumberToWords function. Replace

Code: